PINE64 dev

07 Jan 2021 12:45

minecrell: so I was wondering where the SNPS_PICO_PHY part is for msm8916, because it's not in phy-qcom-usb-hs.c

PINE64 dev

07 Jan 2021 12:42

minecrell: so this code downstream https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/b20608408caff817ec874f325127b07609fbaeb8/drivers/usb/phy/phy-msm-usb.c#L633-L673

PINE64 dev

07 Jan 2021 12:37

konradybcio: imagine people having non-standard pmic+soc combos..

PINE64 dev

07 Jan 2021 12:34

minecrell: But the qcom,hsusb-otg-phy-init-seq contains funny tuning init sequences, and someone had USB stability issues on 8916 when it was wrong at some point. So it may or may not be related

PINE64 dev

07 Jan 2021 12:32

konradybcio: yeah thanks XD

PINE64 dev

07 Jan 2021 12:31

minecrell: on downstream newer platforms using those PHYs are also using entirely different drivers, but there are some similarities

PINE64 dev

07 Jan 2021 12:31

minecrell: There is a funny overlap with the driver you are trying to use (phy-qcom-usb-hs-28nm.c), which is for the femto PHY but they also say support for the pico PHY could be added eventually: https://github.com/torvalds/linux/commit/67b27dbeac4dc86d8f09789861bc8eda6f3538c4

PINE64 dev

07 Jan 2021 12:24

minecrell: Not sure. It doesn't translate very well to mainline atm. Downstream basically has something like phy-qcom-usb-hs.c (an ULPI PHY driver) but with some bits of the init sequence from phy-qcom-usb-hs-28nm.c

PINE64 dev

07 Jan 2021 12:22

konradybcio: how do you see it? should I just add

ulpi {
phy{
qcom-init-seq=foo
}
}

?

PINE64 dev

07 Jan 2021 12:19

konradybcio: uhoh I don't think I have anything to hook up the icc to on this device in the current state

PINE64 dev

07 Jan 2021 12:17

minecrell: the PHY code seems a bit fishy

PINE64 dev

07 Jan 2021 12:16

konradybcio: it can negotiate the address but I don't think the connection is stable

PINE64 dev

07 Jan 2021 12:16

minecrell: konradybcio: did you get USB working?

PINE64 dev

07 Jan 2021 12:14

minecrell: but with network

PINE64 dev

07 Jan 2021 12:13

konradybcio: there's only a single node that doesn't cooperate, which is... SLV_QPIC

PINE64 dev

07 Jan 2021 12:43

minecrell: is in phy-qcom-usb-hs-28nm.c in mainline

PINE64 dev

07 Jan 2021 12:42

minecrell: konradybcio: fun

PINE64 dev

07 Jan 2021 12:37

konradybcio: wait it's supposed to panic when no regulators are assigned?!

PINE64 dev

07 Jan 2021 12:34

konradybcio: so.. I had this.. idea.. https://del.dog/mystistuwi.txt

PINE64 dev

07 Jan 2021 12:31

minecrell: tl;dr good luck xD

PINE64 dev

07 Jan 2021 12:31

minecrell: and this driver appears to be mainly for use with dwc3

PINE64 dev

07 Jan 2021 12:31

minecrell: In the downstream implementation of USB (with chipidea), there is a SNPS_PICO_PHY (e.g. msm8916) and SNPS_FEMTO_PHY (e.g. mdm9607) supported. msm8916 uses phy-qcom-usb-hs.c

PINE64 dev

07 Jan 2021 12:23

konradybcio: moving the femtophy node inside ulpi{} is a no-go, it's a MMIO device supposed to live in /soc

PINE64 dev

07 Jan 2021 12:20

minecrell: Pretty sure qcom,hsusb-otg-phy-init-seq is supposed to be written via ULPI, it doesn't really translate to hsphy_init_seq (which is written to some random memory)

PINE64 dev

07 Jan 2021 12:17

konradybcio: it used to work like 2y ago on sony 8956 with just changed phy init

PINE64 dev

07 Jan 2021 12:16

konradybcio: ip addr that is

PINE64 dev

07 Jan 2021 12:16

konradybcio: it's complicated

PINE64 dev

07 Jan 2021 12:14

konradybcio: qcom even managed to misspell it

PINE64 dev

07 Jan 2021 12:14

minecrell: it's like SoC

PINE64 dev

07 Jan 2021 12:13

konradybcio: now modem has NoC bus scaling:)